fix(operator): use correct parent/child span relationship #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 32.84% 37.99% +5.14%
==========================================
Files 19 28 +9
Lines 1516 2082 +566
==========================================
+ Hits 498 791 +293
- Misses 989 1227 +238
- Partials 29 64 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
reviewed
Nov 15, 2022
|
I guess we might want to fix this in workloadInstance as well https://github.com/keptn/lifecycle-toolkit/blob/main/operator/controllers/keptnworkloadinstance/controller.go#L162 |
At the moment, this is not problematic since the parent/child relationship for Workload is correct. However, this will be reworked with #410 |
odubajDT
previously approved these changes
Nov 16, 2022
RealAnna
changed the title
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
RealAnna
force-pushed
the
fix/336/span-parent
branch
from
9a87943 to
8b7eeaa
Compare
Signed-off-by: RealAnna <[email protected]>
odubajDT
previously approved these changes
Nov 21, 2022
Signed-off-by: RealAnna <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Nov 21, 2022
bacherfl
approved these changes
Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Giovanni Liva [email protected]
Fixes #336